0001095: cpio hardlink support and possible memory leak fix

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001095

[BusyBox] Other

major

always

11-20-06 13:48

11-29-06 08:06

Reporter

eswierk

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.2.x

Summary

0001095: cpio hardlink support and possible memory leak fix

Description

A patch was posted to the busybox list about a month ago adding hardlink support to cpio, and fixing a possible memory leak. Hardlink support is needed to handle initramfs archives.

The attached patch is slightly modified to apply cleanly against BusyBox 1.2.2.1.

Additional Information

Attached Files

busybox-200-cpio-hardlinks.patch [^] (4,467 bytes) 11-20-06 13:48

6.patch [^] (6,289 bytes) 11-20-06 16:53

Relationships

Notes
(0001746) vda 11-20-06 16:43	What is this? statics? why this info in not incorporated into archive_handle? char get_header_cpio(archive_handle_t archive_handle) { static hardlinks_t saved_hardlinks = NULL; static unsigned short pending_hardlinks = 0; static int inode;

(0001747) vda 11-20-06 16:53 edited on: 11-20-06 16:54	# make bloatcheck function old new delta get_header_cpio 999 1059 +60 static.inode - 4 +4 .rodata 193244 193212 -32 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 1/1 up/down: 64/-32) Total: 32 bytes Patch which is going to be applied to svn will be attached now, please test and give feedback. But those statics are butt-ugly!

Issue History
Date Modified	Username	Field	Change
11-20-06 13:48	eswierk	New Issue
11-20-06 13:48	eswierk	Status	new => assigned
11-20-06 13:48	eswierk	Assigned To	=> BusyBox
11-20-06 13:48	eswierk	File Added: busybox-200-cpio-hardlinks.patch
11-20-06 13:49	eswierk	Issue Monitored: eswierk
11-20-06 16:43	vda	Note Added: 0001746
11-20-06 16:53	vda	Note Added: 0001747
11-20-06 16:53	vda	File Added: 6.patch
11-20-06 16:54	vda	Note Edited: 0001747
11-29-06 08:06	vda	Status	assigned => closed
11-29-06 08:06	vda	Resolution	open => fixed
11-29-06 08:06	vda	Fixed in Version	=> 1.2.x