0001077: statusbar eta and ratio calculation overflows without large file support

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001077

[BusyBox] Networking Support

minor

always

10-26-06 09:37

11-21-06 02:43

Reporter

jamesjuran

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.2.x

Summary

0001077: statusbar eta and ratio calculation overflows without large file support

Description

The calculation of eta and ratio (percentage complete) overflows when off_t is 32-bit (when the Large File Support option is turned off) and a large file is downloaded.

Additional Information

The attached patch fixes the issue by always doing the calculation as a long long int. The patch is against the 1.2.2 release.

Attached Files

wget.diff [^] (724 bytes) 10-26-06 09:37

Relationships

Notes
(0001723) jamesjuran 10-26-06 09:40	I omitted the most important word from the summary -- this happens with wget.

(0001748) vda 11-21-06 02:43	Applied in rev16601

Issue History
Date Modified	Username	Field	Change
10-26-06 09:37	jamesjuran	New Issue
10-26-06 09:37	jamesjuran	Status	new => assigned
10-26-06 09:37	jamesjuran	Assigned To	=> BusyBox
10-26-06 09:37	jamesjuran	File Added: wget.diff
10-26-06 09:39	jamesjuran	Issue Monitored: jamesjuran
10-26-06 09:40	jamesjuran	Note Added: 0001723
11-21-06 02:43	vda	Status	assigned => closed
11-21-06 02:43	vda	Note Added: 0001748
11-21-06 02:43	vda	Resolution	open => fixed
11-21-06 02:43	vda	Fixed in Version	=> 1.2.x