0001060: mmap(2) doesn't work on Blackfin in insmod (probably in other pacles too)

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001060

[BusyBox] Kernel Module Support

major

always

10-02-06 23:14

11-21-06 03:58

Reporter

landau

View Status

public

Assigned To

BusyBox

Priority

normal

Resolution

fixed

Status

closed

Product Version

1.2.x

Summary

0001060: mmap(2) doesn't work on Blackfin in insmod (probably in other pacles too)

Description

Blackfin as a no-mmu architecture has spased support for mmap(2). One place I encountered where it doesn't work is insmod (the one for 2.6.x kernels).
The attached patch uses read(2) if mmap(2) fails. This solves the problem for Blackfin and shouldn't hurn anyone with an MMU.

Additional Information

Attached Files

insmod.patch [^] (834 bytes) 10-02-06 23:14

Relationships

Notes
(0001751) vda 11-21-06 03:56	We have this baby instead!! :) xmalloc_open_read_close(filename, &len); BTW, why we bother with mmap() _at _all? Are we afraid of little memcpy() inherent in each read()? It's not like we are going to load gigabytes of modules, eh?

(0001752) vda 11-21-06 03:58	fixed in rev 16606. Consider testing it, though...

Issue History
Date Modified	Username	Field	Change
10-02-06 23:14	landau	New Issue
10-02-06 23:14	landau	Status	new => assigned
10-02-06 23:14	landau	Assigned To	=> BusyBox
10-02-06 23:14	landau	File Added: insmod.patch
11-21-06 03:56	vda	Note Added: 0001751
11-21-06 03:58	vda	Status	assigned => closed
11-21-06 03:58	vda	Note Added: 0001752
11-21-06 03:58	vda	Resolution	open => fixed
11-21-06 03:58	vda	Fixed in Version	=> 1.2.x