0001044: ext2root.mk uses LANG to specify C locale for 'du' instead of LC_ALL

BusyBox Bug and Patch Tracking

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0001044

[buildroot] Other

minor

always

09-23-06 15:23

02-12-07 05:44

Reporter

ambrox8

View Status

public

Assigned To

buildroot

Priority

normal

Resolution

fixed

Status

closed

Product Version

Summary

0001044: ext2root.mk uses LANG to specify C locale for 'du' instead of LC_ALL

Description

ext2root.mk uses LANG enviroment variable to specify C locale for 'du', but it should also specify LC_ALL, as only specifying LANG still causes 'du' to use localised messages instead of english. As a result, not enough space is used and creating the image fails.

Additional Information

to solve this problem change line 85 of ext2root.mk to
GENEXT2_REALSIZE=`LANG=C LC_ALL=C du -l -s -c -k $(TARGET_DIR) | grep total | sed -e "s/total//"`; \

Attached Files

Relationships

Notes
(0001786) bernhardf 11-22-06 15:36	I think that the correct setting is LC_ALL=POSIX Applied. Please report back. Thanks for pointing this out.

(0001810) vapier 11-27-06 07:27	LC_ALL=C is the accepted convention used everywhere, not LC_ALL=POSIX if you set LC_ALL, there's no point in setting LANG

(0001819) bernhardf 11-28-06 00:50	So be it. Fixed in svn. Mike, thanks.

Issue History
Date Modified	Username	Field	Change
09-23-06 15:23	ambrox8	New Issue
09-23-06 15:23	ambrox8	Status	new => assigned
09-23-06 15:23	ambrox8	Assigned To	=> uClibc
11-22-06 15:36	bernhardf	Note Added: 0001786
11-27-06 07:27	vapier	Note Added: 0001810
11-28-06 00:50	bernhardf	Status	assigned => closed
11-28-06 00:50	bernhardf	Note Added: 0001819
11-28-06 00:50	bernhardf	Resolution	open => fixed
02-12-07 05:44	vapier	Status	closed => assigned
02-12-07 05:44	vapier	Assigned To	uClibc => buildroot