BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001038 [BusyBox] Other major always 09-20-06 01:24 09-20-06 08:30
Reporter rockeychu View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version svn
Summary 0001038: "cmp" can't use options
Description patch as following:

--- busybox_org/coreutils/cmp.c 2006-09-04 17:55:30.000000000 +0800
+++ busybox/coreutils/cmp.c 2006-09-20 16:08:46.282088000 +0800
@@ -56,7 +56,7 @@

        opt = bb_getopt_ulflags(argc, argv, opt_chars);

- if ((opt & (CMP_OPT_s|CMP_OPT_l))
+ if (((opt & (CMP_OPT_s|CMP_OPT_l)) == 3)
                        || (((unsigned int)(--argc - optind)) > 1))
                bb_show_usage();

@@ -103,7 +103,7 @@
                                 * make sure we fflush before writing to stderr. */
                                xfflush_stdout();
                        }
- if (!opt & CMP_OPT_s) {
+ if (!(opt & CMP_OPT_s)) {
                                if (opt & CMP_OPT_l) {
                                        line_pos = c1; /* line_pos is unused in the -l case. */
                                }
Additional Information
Attached Files

- Relationships

- Notes
(0001639)
bernhardf
09-20-06 08:30

Fixed in r16162. Thanks for spotting this..
 

- Issue History
Date Modified Username Field Change
09-20-06 01:24 rockeychu New Issue
09-20-06 01:24 rockeychu Status new => assigned
09-20-06 01:24 rockeychu Assigned To  => BusyBox
09-20-06 08:30 bernhardf Status assigned => closed
09-20-06 08:30 bernhardf Note Added: 0001639
09-20-06 08:30 bernhardf Resolution open => fixed
09-20-06 08:30 bernhardf Fixed in Version  => svn


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker