BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0001037 [BusyBox] Other block always 09-19-06 21:04 11-29-06 06:45
Reporter rockeychu View Status public  
Assigned To BusyBox
Priority normal Resolution fixed  
Status closed   Product Version
Summary 0001037: "mount" problem on using return value of bb_getopt_ulflags()
Description Very serious!

--- busybox_org/util-linux/mount.c 2006-09-20 09:50:04.000000000 +0800
+++ busybox/util-linux/mount.c 2006-09-20 11:56:09.550580000 +0800
@@ -1429,7 +1429,7 @@

 int mount_main(int argc, char **argv)
 {
- enum { OPT_ALL = 0x8 };
+ enum { OPT_ALL = 0x10 };

        char *cmdopts = xstrdup(""), *fstype=0, *storage_path=0;
        char *opt_o;
@@ -1454,17 +1454,17 @@
        opt = bb_getopt_ulflags(argc, argv, "o:t:rwavnf", &opt_o, &fstype);
        if (opt & 1) // -o
                append_mount_options(&cmdopts, opt_o);
- //if (opt & 1) // -t
- if (opt & 2) // -r
+ //if (opt & 2) // -t
+ if (opt & 4) // -r
                append_mount_options(&cmdopts, "ro");
- if (opt & 4) // -w
+ if (opt & 8) // -w
                append_mount_options(&cmdopts, "rw");
- //if (opt & 8) // -a
- if (opt & 0x10) // -n
+ //if (opt & 0x10) // -a
+ if (opt & 0x40) // -n
                USE_FEATURE_MTAB_SUPPORT(useMtab = FALSE);
- if (opt & 0x20) // -f
+ if (opt & 0x80) // -f
                USE_FEATURE_MTAB_SUPPORT(fakeIt = FALSE);
- //if (opt & 0x40) // ignore -v
+ //if (opt & 0x20) // ignore -v
        argv += optind;
        argc -= optind;

Additional Information
Attached Files

- Relationships

- Notes
(0001835)
vda
11-29-06 06:45

Fixed sometime ago in svn
 

- Issue History
Date Modified Username Field Change
09-19-06 21:04 rockeychu New Issue
09-19-06 21:04 rockeychu Status new => assigned
09-19-06 21:04 rockeychu Assigned To  => BusyBox
11-29-06 06:45 vda Status assigned => closed
11-29-06 06:45 vda Note Added: 0001835
11-29-06 06:45 vda Resolution open => fixed
11-29-06 06:45 vda Fixed in Version  => 1.2.x


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker