BusyBox Bug and Patch Tracking
BusyBox
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000001 [BusyBox] Other minor N/A 01-13-05 01:45 09-01-05 02:05
Reporter msvoboda View Status public  
Assigned To BusyBox
Priority normal Resolution open  
Status closed   Product Version 1.00
Summary 0000001: swapoff during restart/poweroff
Description This patch modifies init.c so when swapon/off is
not included in the busybox package it dosen't run
swapoff during poweroff/restart with builtin inittab.
Additional Information --- init-old.c 2004-10-08 10:21:54.000000000 +0200
+++ init.c 2004-12-21 13:11:31.136591100 +0100
@@ -960,7 +960,7 @@
        new_init_action(CTRLALTDEL, "/sbin/reboot", "");
        /* Umount all filesystems on halt/reboot */
        new_init_action(SHUTDOWN, "/bin/umount -a -r", "");
-#if !defined(__UCLIBC__) || defined(__ARCH_HAS_MMU__)
+#if defined(CONFIG_SWAPONOFF) && (!defined(__UCLIBC__) ||
defined(__ARCH_HAS_MMU__))
        /* Swapoff on halt/reboot */
        new_init_action(SHUTDOWN, "/sbin/swapoff -a", "");
 #endif
Attached Files

- Relationships

- Notes
(0000343)
pgf
07-26-05 14:15

this fix ties together two different things: one is whether swapoff is built in to busybox, and the other is whether it should be called during shutdown. just because it's not built-in doesn't mean it shouldn't be called.

(i don't disagree that the shutdown behavior should be controllable, but this is not the right way to control it.)
 
(0000476)
landley
09-01-05 02:05

r11290
 

- Issue History
Date Modified Username Field Change
01-13-05 01:45 msvoboda New Issue
03-16-05 12:26 andersen Assigned To andersen => BusyBox
07-26-05 14:15 pgf Note Added: 0000343
09-01-05 02:05 landley Note Added: 0000476
09-01-05 02:05 landley Status assigned => closed


Copyright © 2000 - 2006 Mantis Group
Powered by Mantis Bugtracker