changeset 1145:80c9df5145fe draft

Move names_to_pid from pending to lib.
author Rob Landley <rob@landley.net>
date Thu, 19 Dec 2013 09:32:30 -0600
parents 58daf9c9a0b1
children 3570984a1015
files lib/lib.c lib/lib.h lib/pending.c lib/pending.h
diffstat 4 files changed, 26 insertions(+), 30 deletions(-) [+]
line wrap: on
line diff
--- a/lib/lib.c	Wed Dec 18 10:25:02 2013 -0600
+++ b/lib/lib.c	Thu Dec 19 09:32:30 2013 -0600
@@ -710,3 +710,28 @@
   else c = '-';
   *buf = c;
 }
+
+// Execute a callback for each PID that matches a process name from a list.
+void names_to_pid(char **names, int (*callback)(pid_t pid, char *name))
+{
+  DIR *dp;
+  struct dirent *entry;
+
+  if (!(dp = opendir("/proc"))) perror_exit("opendir");
+
+  while ((entry = readdir(dp))) {
+    unsigned u;
+    char *cmd, **curname;
+
+    if (!(u = atoi(entry->d_name))) continue;
+    sprintf(libbuf, "/proc/%u/cmdline", u);
+    if (!(cmd = readfile(libbuf, libbuf, sizeof(libbuf)))) continue;
+
+    for (curname = names; *curname; curname++)
+      if (**curname == '/' ? !strcmp(cmd, *curname)
+          : !strcmp(basename(cmd), basename(*curname)))
+        if (callback(u, *curname)) break;
+    if (*curname) break;
+  }
+  closedir(dp);
+}
--- a/lib/lib.h	Wed Dec 18 10:25:02 2013 -0600
+++ b/lib/lib.h	Thu Dec 19 09:32:30 2013 -0600
@@ -177,5 +177,6 @@
 
 mode_t string_to_mode(char *mode_str, mode_t base);
 void mode_to_string(mode_t mode, char *buf);
+void names_to_pid(char **names, int (*callback)(pid_t pid, char *name));
 
 #include "lib/pending.h"
--- a/lib/pending.c	Wed Dec 18 10:25:02 2013 -0600
+++ b/lib/pending.c	Thu Dec 19 09:32:30 2013 -0600
@@ -5,31 +5,6 @@
 
 #include "toys.h"
 
-// Execute a callback for each PID that matches a process name from a list.
-void names_to_pid(char **names, int (*callback)(pid_t pid, char *name))
-{
-  DIR *dp;
-  struct dirent *entry;
-
-  if (!(dp = opendir("/proc"))) perror_exit("opendir");
-
-  while ((entry = readdir(dp))) {
-    unsigned u;
-    char *cmd, **curname;
-
-    if (!(u = atoi(entry->d_name))) continue;
-    sprintf(libbuf, "/proc/%u/cmdline", u);
-    if (!(cmd = readfile(libbuf, libbuf, sizeof(libbuf)))) continue;
-
-    for (curname = names; *curname; curname++)
-      if (**curname == '/' ? !strcmp(cmd, *curname)
-          : !strcmp(basename(cmd), basename(*curname)))
-        if (callback(u, *curname)) break;
-    if (*curname) break;
-  }
-  closedir(dp);
-}
-
 void daemonize(void)
 {
   int fd = open("/dev/null", O_RDWR);
--- a/lib/pending.h	Wed Dec 18 10:25:02 2013 -0600
+++ b/lib/pending.h	Thu Dec 19 09:32:30 2013 -0600
@@ -8,11 +8,6 @@
 typedef float FLOAT;
 //#endif
 
-// libc generally has this, but the headers are screwed up
-ssize_t getline(char **lineptr, size_t *n, FILE *stream);
-
-void names_to_pid(char **names, int (*callback)(pid_t pid, char *name));
-
 // password.c
 #define MAX_SALT_LEN  20 //3 for id, 16 for key, 1 for '\0'
 #define SYS_FIRST_ID  100